PaulHowarth/Blog/2012-03-01

Thursday 1st March 2012

Fedora Project

Cleaned up and rebuilt perl-Readonly and perl-Readonly-XS in F-17 and Rawhide, the biggest change being to get rid of the tests subpackages and re-integrating them with the main package

Local Packages

Updated perl-DateTime-TimeZone to 1.43:
- This release is based on version 2012a of the Olson database
- Contemporary changes for Armenia, Chile, the Falkland Islands, and Tokelau
Updated perl-Params-Util to 1.06:
- Restore compatibility with pre-5.8.8 Perls without a working compiler available at install time (CPAN RT#74912)
- Remove the need for the sanexs.c file by generating into a temporary file instead
With suitable tweaking of required Scalar::Utils versions, this version builds and passes its test suite all the way back to RHL-9 with Scalar::Util 1.09, so I dropped the branch of version 0.17 I'd kept around for old distributions
Updated perl-Moose to drop the patch I had to support using it with old Params::Util versions and made it build-require perl(Params::Util) ≥ 1.00 instead
Updated perl-Perl-Critic to bundle Test::More, Test::Builder and Test::Builder::Module 0.92 and put them in inc/; this enables us to get Perl::Critic built and tested OK on FC-3, FC-4 and RHEL-4, and other workarounds for old Test::More versions aren't needed
Older distributions with Exporter < 5.58 still won't work, failing with:

":color_severity" is not exported by the Perl::Critic::Utils::Constants module

Updated perl-Perl-Critic-More to hack t/20_policies_codelayout.t to get it to work with perl < 5.8.8:

Perls/Perl::Critics prior to 5.8.8 seem to have trouble parsing the
Japanese text, and end up with a string containing the same text twice,
causing two violations instead of one.

This slight change to the syntax, in line with the rest of the tests,
eliminates this issue.

--- t/20_policies_codelayout.t
+++ t/20_policies_codelayout.t
@@ -53,7 +53,9 @@
 #----------------------------------------------------------------
 
 $code = <<'END_PERL';
-print "日本語\n";
+print <<'EOF';
+日本語
+EOF
 END_PERL
 
 $policy = 'CodeLayout::RequireASCII';

Built perl-Perl-Critic-Lax and perl-Test-Perl-Critic for FC-3, FC-4 and RHEL-4 since Perl::Critic is now available for those distributions
Rebuilt perl-Readonly and perl-Readonly-XS to re-sync with the Fedora versions
Updated php4-pcntl to get it to build with pcre 8.30 in Rawhide, using a similar patch to the one added for PHP 5.x:

Replace the long-deprecated pcre_info() with pcre_fullinfo()

https://bugs.php.net/bug.php?id=60986
https://bugs.gentoo.org/show_bug.cgi?id=402357#c10

--- php-4.4.9/ext/pcre/php_pcre.c
+++ php-4.4.9/ext/pcre/php_pcre.c
@@ -154,10 +154,11 @@
        regex_len = strlen(regex);
        if (zend_hash_find(&PCRE_G(pcre_cache), regex, regex_len+1, (void **)&pce) == SUCCESS) {
                /*
-                * We use a quick pcre_info() check to see whether cache is corrupted, and if it
+                * We use a quick pcre_fullinfo() check to see whether cache is corrupted, and if it
                 * is, we flush it and compile the pattern from scratch.
                 */
-               if (pcre_info(pce->re, NULL, NULL) == PCRE_ERROR_BADMAGIC) {
+               int count = 0;
+               if (pcre_fullinfo(pce->re, NULL, PCRE_INFO_CAPTURECOUNT, &count) == PCRE_ERROR_BADMAGIC) {
                        zend_hash_clean(&PCRE_G(pcre_cache));
                } else {
 #if HAVE_SETLOCALE

Rebuilt php4-pcntl-gtk using -fno-strict-aliasing since the code is full of dubious pointer conversions
Built perl-DBD-CSV and perl-SQL-Statement for FC-1 and FC-2 since their requirement of Params::Util 1.x is now available